Search Linux Wireless

Re: [PATCH] wifi: nl80211: Avoid address calculations via out of bounds array indexing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>
Subject: Re: [PATCH] wifi: nl80211: Avoid address calculations via out of bounds array indexing
From: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
Date: Tue, 30 Apr 2024 12:59:57 -0700
Cc: Nathan Chancellor <nathan@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, <linux-wireless@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-hardening@xxxxxxxxxxxxxxx>
In-reply-to: <e2f20484fb1f4607d099d2184c1d74c6a39febc1.camel@sipsolutions.net>
References: <20240424220057.work.819-kees@kernel.org> <e2f20484fb1f4607d099d2184c1d74c6a39febc1.camel@sipsolutions.net>
User-agent: Mozilla Thunderbird

On 4/30/2024 3:01 AM, Johannes Berg wrote:
> This really doesn't even seem right, shouldn't do pointer arithmetic on
> void pointers.

FWIW I argued this in the past in another context and Linus gave his opinion:

https://lore.kernel.org/all/CAHk-=whFKYMrF6euVvziW+drw7-yi1pYdf=uccnzJ8k09DoTXA@xxxxxxxxxxxxxx/

Follow-Ups:
- Re: [PATCH] wifi: nl80211: Avoid address calculations via out of bounds array indexing
  - From: Kees Cook

References:
- [PATCH] wifi: nl80211: Avoid address calculations via out of bounds array indexing
  - From: Kees Cook
- Re: [PATCH] wifi: nl80211: Avoid address calculations via out of bounds array indexing
  - From: Johannes Berg

Prev by Date: Re: [PATCHv4 3/3] wifi: ath12k: Remove unused tcl_*_ring configuration
Next by Date: Re: [PATCH] wifi: nl80211: Avoid address calculations via out of bounds array indexing
Previous by thread: Re: [PATCH] wifi: nl80211: Avoid address calculations via out of bounds array indexing
Next by thread: Re: [PATCH] wifi: nl80211: Avoid address calculations via out of bounds array indexing
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]