On 4/29/2024 5:08 AM, Kalle Valo wrote:
Pradeep Kumar Chitrapu <quic_pradeepc@xxxxxxxxxxx> writes:
On 4/26/2024 12:31 AM, Kalle Valo wrote:
Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes:
On 4/24/2024 1:19 PM, Pradeep Kumar Chitrapu wrote:
Add support to set fixed HE rate/GI/LTF values using nl80211.
Reuse parts of the existing code path already used for HT/VHT
to implement the new helpers symmetrically, similar to how
HT/VHT is handled.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
Co-developed-by: Muna Sinada <quic_msinada@xxxxxxxxxxx>
Signed-off-by: Muna Sinada <quic_msinada@xxxxxxxxxxx>
Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc@xxxxxxxxxxx>
---
[...]
@@ -7753,7 +8034,20 @@ ath12k_mac_bitrate_mask_get_single_nss(struct ath12k *ar,
return false;
}
- if (ht_nss_mask != vht_nss_mask)
+ he_mcs_map = le16_to_cpu(ath12k_mac_get_tx_mcs_map(&sband->iftype_data->he_cap));
drivers/net/wireless/ath/ath12k/mac.c:8041:22: warning: incorrect type in argument 1 (different address spaces)
drivers/net/wireless/ath/ath12k/mac.c:8041:22: expected struct ieee80211_sta_he_cap const *he_cap
drivers/net/wireless/ath/ath12k/mac.c:8041:22: got struct ieee80211_sta_he_cap const [noderef] __iftype_data *
ALWAYS run ath12k-check, we wrote the tool for a reason. Skipping
these
tests is disrespect for maintainers' time and a great way to get your
patches to the bottom of the queue.
Hi Kalle
I did run ath12k-check but I don't see these errors. Trying to see if
this is due to version differences. will update further once I have
more information on this.
This is version I ran:
qca-swiss-army-knife/tools/scripts/ath12k/ath12k-check --version
ath12k-check (md5sum cb8a85242f2ec7343f6f94af9fa5ebb2)
python: 3.6.9 (default, Mar 10 2023, 16:46:00)
[GCC 8.4.0]
host gcc: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
config cc: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
sparse: v0.6.4
checkpatch.pl: Version: 0.32 (md5sum 12ea394e9bf27280f30a684ff937cc57)
gtags: gtags (GNU GLOBAL) 6.6.2
Your sparse is too old, you need to get the latest from git:
https://docs.kernel.org/dev-tools/sparse.html#getting-sparse
Thanks Kalle and Jeff for sharing the tool versions required..
I am able to see the errors reported now..
will fix and respin the series..
ath12k-check (md5sum cb8a85242f2ec7343f6f94af9fa5ebb2)
python: 3.6.9 (default, Mar 10 2023, 16:46:00)
[GCC 8.4.0]
host gcc: gcc (GCC) 13.2.0
config cc: gcc (GCC) 13.2.0
sparse: v0.6.4-66-g0196afe16a50
checkpatch.pl: Version: 0.32 (md5sum 12ea394e9bf27280f30a684ff937cc57)
gtags: gtags (GNU GLOBAL) 6.6.2
Thanks
Pradeep
Also your GCC is really old, I strongly recommend to use GCC 13.2. You
can get it here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/
Why on earth are you using Ubuntu 18.04? It's end of life was a year
ago.
Will get update ubuntu in few days.
And please also update ath12k-check. This is what I have:
$ ath12k-check --version
ath12k-check (md5sum c5567fc8aaede613275e8cafea6ed7cd)
python: 3.11.2 (main, Mar 13 2023, 12:18:29) [GCC 12.2.0]
host gcc: gcc (Debian 12.2.0-14) 12.2.0
config cc: x86_64-linux-gcc (GCC) 13.2.0
sparse: v0.6.4-39-gce1a6720f69e
checkpatch.pl: Version: 0.32 (md5sum 77c655474ed7622c0077caf2f0d7c440)
gtags: gtags (Global) 6.6.9
I see some notes like below this in all files:
drivers/net/wireless/ath/ath12k/mac.c: note: in included file (through
include/linux/bitops.h, include/linux/kernel.h,
include/net/mac80211.h):
drivers/net/wireless/ath/ath12k/mac.c: note: in included file (through
include/linux/bitops.h, include/linux/kernel.h,
include/net/mac80211.h):
Jeff and me are extra careful that there are no warnings in ath12k, in
fact in wireless-next the whole wireless subsystem has no sparse
warnings. So if you ever see warnings please report them to maintainers
ASAP.
