Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: > Ping-Ke Shih wrote: >> Kalle Valo <kvalo@xxxxxxxxxx> wrote: >> > I noticed by random that rtl8xxxu includes linux/wireless.h even though it >> > doesn't need it. While investigating a bit more I found even more unused >> > include files: >> > >> > #include <linux/init.h> >> > #include <linux/sched.h> >> > #include <linux/ethtool.h> >> > >> > It looks like that the includes are just copied to every file without checking >> > if the file really needs the include. So more includes could be removed but >> > that would need more careful analysis per each file. >> >> I can do that. My ways will be to create an empty (new) C file to examine >> every driver's header file can be included individually, and then try-and-error >> to remove includes from existing C files. > > I made a patch [1] followed above ways based on these two patches. Excellent, thanks Ping. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
