On 4/24/2024 1:19 PM, Pradeep Kumar Chitrapu wrote:
> Currently, only the HE IE in management frames is updated with
> respect to MU-MIMO configurations, but this change is not
> reflected in the hardware. Add support to propagate MU-MIMO
> configurations to the hardware as well.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Co-developed-by: Muna Sinada <quic_msinada@xxxxxxxxxxx>
> Signed-off-by: Muna Sinada <quic_msinada@xxxxxxxxxxx>
> Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc@xxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath12k/mac.c | 214 +++++++++++++++++---------
> drivers/net/wireless/ath/ath12k/mac.h | 15 ++
> drivers/net/wireless/ath/ath12k/wmi.h | 28 +---
> 3 files changed, 155 insertions(+), 102 deletions(-)
>
[...]
> static void ath12k_bss_assoc(struct ath12k *ar,
> struct ath12k_vif *arvif,
> struct ieee80211_bss_conf *bss_conf)
drivers/net/wireless/ath/ath12k/mac.c:2816:13: warning: context imbalance in 'ath12k_bss_assoc' - wrong count at exit
see reason below
> {
> struct ieee80211_vif *vif = arvif->vif;
> struct ath12k_wmi_peer_assoc_arg peer_arg;
> + struct ieee80211_sta_he_cap he_cap;
> struct ieee80211_sta *ap_sta;
> struct ath12k_peer *peer;
> bool is_auth = false;
> + u32 hemode = 0;
> int ret;
>
> lockdep_assert_held(&ar->conf_mutex);
> @@ -2556,8 +2660,28 @@ static void ath12k_bss_assoc(struct ath12k *ar,
>
> ath12k_peer_assoc_prepare(ar, vif, ap_sta, &peer_arg, false);
>
> + /* he_cap here is updated at assoc success for sta mode only */
> + he_cap = ap_sta->deflink.he_cap;
> +
> + /* ap_sta->deflink.he_cap must be protected by rcu_read_lock */
> + ret = ath12k_mac_vif_recalc_sta_he_txbf(ar, vif, &he_cap, &hemode);
> + if (ret) {
> + ath12k_warn(ar->ab, "failed to recalc he txbf for vdev %i on bss %pM: %d\n",
> + arvif->vdev_id, bss_conf->bssid, ret);
> + return;
bad return within rcu_read_lock() critical section
> + }
> +
> rcu_read_unlock();
>
