On Wed, 2024-04-24 at 12:26 +0530, Karthikeyan Periyasamy wrote: > Currently, hardware state is not protected across the reconfigure > operations. However, in single wiphy models, multiple radio/links is > exposed as a MAC hardware (ieee80211_hw) through the driver hardware > abstraction (ath12k_hw) layer. In such scenario, we need to protect > hardware state across the multiple radio/link at the driver hardware > abstraction (ath12k_hw) layer. Therefore, introduce a new mutex in > the ath12k_hw layer. > It's your driver, but ... it would seem _simpler_ to do locking across the hw with a single wiphy model, because everything (except currently for ath12k_core_reset and ath12k_core_restart) already holds the wiphy mutex. You can probably move those to wiphy work. I'd avoid doing lock explosion like we had in mac80211, it's going to come back and bite you eventually :) johannes
