On Tue, 2024-04-23 at 11:46 -0700, Jeff Johnson wrote: > > Johannes, how do you feel about the new cleanup.h functionality? I ask because > if we change this to just be: > > guard(rcu)(); > > then we can remove all of the explicit rcu_read_unlock() calls -- > rcu_read_unlock() will be called automatically when the function goes out of > scope. Sounds like a good idea to me. Jakub doesn't like it so much, see this thread: https://lore.kernel.org/netdev/20240325223905.100979-5-johannes@xxxxxxxxxxxxxxxx/ But ultimately I don't think he'll stop us from doing it here, especially if we use it carefully enough that we actually do need the guard for the whole scope. johannes
