On 4/19/2024 2:12 AM, Johannes Berg wrote: > Sparse complains on these patches. I think everyone at QCA should be > able to *consistently* run that. > > Jeff, do you really have no internal processes, it all depends on people > running checks manually? We have our own internal tree first, where CI > enforces a whole bunch of things, and *then* we send patches out. We are trying to get there but, as the community knows, Qualcomm has historically had a "downstream first" mentality, so all of our automation is built around that. The good news is that there has recently been a massive shift in philosophy (and one reason why after many years of working on the downstream Android driver I moved to the upstream driver). At Linaro Connect 2023 (<https://www.qualcomm.com/developer/blog/2023/06/highlights-linaro-connect-2023>) Leendert van Doorn, SVP of Engineering, announced "Qualcomm is about to adopt a developer first strategy" and "embrace open source and its upstream contribution model." So more resources are being directed at upstream, including updating CI to support that. In the meantime, in my personal semi-automated review workflow I run sparse via ath1*k-check, but unfortunately that only looks in drivers/net/wireless/ath/ath1*k. I have now updated my workflow to check all of the files that are modified by a given patchset, and that flagged: net/mac80211/cfg.c:4847:1: warning: context imbalance in 'ieee80211_obss_color_collision_notify' - different lock contexts for basic block So hopefully in the future I'll catch issues like these internally, before they escape into public. /jeff
