On 22/04/2024 06:13, Ping-Ke Shih wrote: > Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote: >> Improve readability: >> * add empty lines >> * use abs_diff in rtl92d_dm_txpower_tracking_callback_thermalmeter >> * roll up repeated statements into a for loop in >> rtl92d_dm_txpower_tracking_callback_thermalmeter >> * shorten lines by replacing many instances of "rtlpriv->dm" with "dm" >> pointer in rtl92d_dm_txpower_tracking_callback_thermalmeter >> * sort some declarations by length >> * refactor _rtl92d_get_txpower_writeval_by_regulatory a little >> * refactor _rtl92de_readpowervalue_fromprom a little >> >> Delete unused structs tag_dynamic_init_gain_operation_type_definition >> and swat. >> >> Simplify rtl92d_fill_h2c_cmd a little and delete a pointless wrapper >> function. >> >> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > > Thanks for the cleanup and test. Please also provide tested devices > to me. > > Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > I tested with something called "CC&C WL-6210-V3" -- single MAC single PHY, sold on Aliexpress without a case. I will put this in the commit message in v7.
