On Sat, Dec 6, 2008 at 7:59 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Sat, 2008-12-06 at 16:46 +0100, Henning Rogge wrote: >> On Saturday 06 December 2008 16:03:16 Henning Rogge wrote: >> > > I'd rename _TOTAL to _LEGACY and remove the calculation for MCS rates, >> > > that way it's obviously clear what you're getting in userland. >> Okay, after reading your mail a second time I understood you... >> >> I think with removing the total bitrate for 802.11n we will just make the >> userspace interface more complex. You will have to look at four different >> things (flags, MCS, guard interval, legacy) just to get the bitrate, which >> will be the typical information the user wants to know. Is there anything >> nl80211 will gain if we don't put this value inside for all 802.11 ? We cannot >> drop it because of 802.11abg, so why not fill it with useful data ? > > For one, I'm a bit concerned that the calculation is fairly complex, and > may not always be necessary; especially divisions can be expensive on > some CPUs. > > Also, there are duplicate numbers possible, so just the pure bitrate > will _not_ actually be "the typical information" because it's not > specific enough, when debugging, for example, you will probably need to > know whether it's short-gi or not. Aren't we providing that *as well*? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
