Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
> Software control (on/off) and hardware control (automatic blinking)
> tested with EDUP EP-N8568.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
Checkpatch warns:
WARNING: Missing a blank line after declarations
#28: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1711:
+ u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2);
+ ledcfg &= LEDCFG2_DPDT_SELECT;
WARNING: braces {} are not necessary for any arm of this statement
#30: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1713:
+ if (brightness == LED_OFF) {
[...]
+ } else if (brightness == LED_ON) {
[...]
+ } else if (brightness == RTL8XXXU_HW_LED_CONTROL) {
[...]
Set patchset state to Changes Requested
[v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU
---
https://github.com/pkshih/rtw.git
