> From: Francesco Dolcini <francesco@xxxxxxxxxx> > Sent: Thursday, April 18, 2024 2:38 PM > To: David Lin <yu-hao.lin@xxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > briannorris@xxxxxxxxxxxx; kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete > Hsieh <tsung-hsien.hsieh@xxxxxxx>; Francesco Dolcini > <francesco.dolcini@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for client > mode > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Thu, Apr 18, 2024 at 02:06:25PM +0800, David Lin wrote: > > Add host based MLME to enable WPA3 functionalities in client mode. > > This feature required a firmware with the corresponding V2 Key API > > support. The feature (WPA3) is currently enabled and verified only on > > IW416. Also, verified no regression with change when host MLME is > > disabled. > > > > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx> > > Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > ... > > > diff --git a/drivers/net/wireless/marvell/mwifiex/util.c > > b/drivers/net/wireless/marvell/mwifiex/util.c > > index 745b1d925b21..3817c08a1507 100644 > > --- a/drivers/net/wireless/marvell/mwifiex/util.c > > +++ b/drivers/net/wireless/marvell/mwifiex/util.c > > @@ -417,6 +456,47 @@ mwifiex_process_mgmt_packet(struct > > mwifiex_private *priv, > > ... > > > + mwifiex_dbg > > + (priv->adapter, MSG, > > + "assoc: receive disassoc from %pM\n", > > + ieee_hdr->addr3); > > The way you indented this does not seems kernel coding style compliant ... > however checkpatch does not complain ... so maybe I am just wrong. > > In case you need to send a new version, please keep the open parenthesis > together with the function name > > mwifiex_dbg(priv->adapter, MSG, > "assoc: receive disassoc > from %pM\n", > ieee_hdr->addr3); > > (yes, it's 81 column - and it's fine). > > Again, IMHO, do not send a v11 just for this trivial change. > > Francesco > Because checkpatch.pl doesn't complain about this kind of coding, I use this way to let code less and equal 80. I will correct it if new version of code is needed. David
