Search Linux Wireless

RE: [PATCH] wifi: rtw88: suppress messages of failed to flush queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lewis Robbins <lewis.robbins2@xxxxxxxxx> wrote:

> Thanks, I tested it for 30 minutes and didn't receive any superfluous warning message. Only thing I could
> find was the comment above not reflecting the (new) debug print (but very nit-picky from me).
> 
> Acked-by: Lewis Robbins <lewis.robbins2@xxxxxxxxx>

Acked-by is used by maintainers, so I used your Tested-by by v2. [1]

> 
> diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
> index 9038e2311596..3d1a886262d8 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac.c
> @@ -1026,7 +1026,7 @@ static void __rtw_mac_flush_prio_queue(struct rtw_dev *rtwdev,
>                 msleep(20);
>         }
> 
> -       /* priority queue is still not empty, throw a warning,
> +       /* priority queue is still not empty, throw a debug message

Thanks for pointing this. 

>          *
>          * Note that if we want to flush the tx queue when having a lot of
>          * traffic (ex, 100Mbps up), some of the packets could be dropped.

[1] https://lore.kernel.org/linux-wireless/20240418002916.5965-1-pkshih@xxxxxxxxxxx/T/#u






[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux