Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: > > > Hi Kalle, > > > > Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx> wrote: > > > >> Hi Ping-Ke, > >> > >> Am 15.04.24 um 21:14 schrieb Bitterblue Smith: > >> > On 15/04/2024 09:49, Martin Kaistra wrote: > >> >> Am 14.04.24 um 13:32 schrieb Bitterblue Smith: > >> >>> On 14/03/2024 18:48, Martin Kaistra wrote: > >> >>> > >> >>> Also, won't you send the patch to the stable tree? > >> >> > >> >> The rtl8xxxu driver previously did not have the MFP_CAPABLE flag > >> >> set. As I am adding new functionality > >> (support for WPA3), I don't think this should go to stable. > >> > > >> > Without your patch I can't connect to my phone's hotspot > >> > when it uses WPA3: > >> > > >> > Apr 08 12:50:57 ideapad2 wpa_supplicant[1231]: nl80211: kernel > >> > reports: key setting validation failed > >> > Apr 08 12:50:57 ideapad2 wpa_supplicant[1231]: wlp3s0f3u2: WPA: > >> > Failed to configure IGTK to the driver > >> > Apr 08 12:50:57 ideapad2 wpa_supplicant[1231]: wlp3s0f3u2: RSN: > >> > Failed to configure IGTK > >> > > >> > It doesn't say anything about WPA3 or management frame > >> > protection, just prints those unhelpful errors and tries > >> > to connect over and over again. To me that looks more like > >> > fixing a bug than adding new functionality. It's just sad > >> > that people need to install kernel 6.10+ in order to support > >> > WPA3, when the patch is so small. > >> > >> I would like to know your opinion on this. imho this patch should not go to > >> stable and I would therefore propose to just send a patch to improve the checks. > >> If you as a maintainer however say, you would like to see this in stable, then I > >> will send a revert and a new patch. > >> > > > > We have a question about MFP support to stable tree. rtl8xxxu never supports MFP, > > and recently we have a small patch (10+ LOC) to enable that. I feel we should > > treat it as new feature, not add to stable tree. But as Bitterblue mentioned, > > it looks like a bug. Need your opinion. > > I assume you are talking about this patch: > > https://lore.kernel.org/all/20240314164850.86432-1-martin.kaistra@xxxxxxxxxxxxx/ > > I have no strong opinion here. To me it also looks like a new feature > but it might fall within "Serious issues as reported by a user of a > distribution kernel may also be considered if they fix a notable > performance or interactivity issue" stable kernel rule: > > https://docs.kernel.org/process/stable-kernel-rules.html > > Maybe go with 'Option 2'? That is, wait for the commit to go to Linus' > tree, send a mail to stable maintainers explaining the situation and let > them decide. But I would be fine with 'Option 1' as well, your call :) > Thanks for your inputs, Kalle. :) Hi Martin, Bitterblue had a simple way [1] to support MFP, if that also works to you, I think we can revert your original patch [2], and add an new one with Cc stable. If that doesn't work to you, let's keep your patch and go via 'Option 2'. [1] https://lore.kernel.org/linux-wireless/ed12ec17-ae6e-45fa-a72f-23e0a34654da@xxxxxxxxx/ [2] https://lore.kernel.org/all/20240314164850.86432-1-martin.kaistra@xxxxxxxxxxxxx/
