Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote: > > Don't subtract 1 from the power index. This was added in commit > 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts") > for unknown reasons. The vendor drivers don't do this. > > Also correct the calculations of values written to > REG_OFDM0_X{C,D}_TX_IQ_IMBALANCE. According to the vendor driver, > these are used for TX power training. > > With these changes rtl8xxxu sets the TX power of RTL8192CU the same > as the vendor driver. > > None of this appears to have any effect on my RTL8192CU device. IIRC TX power is in unit of 0.5 dBm, so that would not be significant to throughput. > > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> I checked logic of changes is the same as vendor driver now. Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>