On 4/12/2024 2:45 AM, Lingbo Kong wrote: > On 2024/4/12 5:51, Jeff Johnson wrote: >> On 4/10/2024 7:53 PM, Lingbo Kong wrote: >>> +struct ath12k_wmi_vdev_stats { >> >> this name does not conform to the "Naming conventions for structures" outlined >> at the beginning of the file: >> * _params is a structure which is embedded either into _cmd or _event (or >> * both), it is not sent individually. >> > > Oh, thanks for pointing out. > I get what you mean, but the ath12k_wmi_vdev_stats belongs to event, so, > i can changes it to wmi_vdev_stats_event, i will apply it in next version. note that _event should only be used for the first TLV in the event payload. Any subsequent TLVs in either a command or event should use _params