Hello Kalle, On Fri, Apr 05, 2024 at 06:15:05PM +0300, Kalle Valo wrote: > Breno Leitao <leitao@xxxxxxxxxx> writes: > > > struct net_device shouldn't be embedded into any structure, instead, > > the owner should use the private space to embed their state into > > net_device. > > > > This patch set fixes the problem above for ath10k and ath11k. This also > > fixes the conversion of qtnfmac driver to the new helper. > > > > This patch set depends on a series that is still under review: > > https://lore.kernel.org/all/20240404114854.2498663-1-leitao@xxxxxxxxxx/#t > > > > If it helps, I've pushed the tree to > > https://github.com/leitao/linux/tree/wireless-dummy > > > > PS: Due to lack of hardware, unfortunately all these patches are > > compiled tested only. > > > > Breno Leitao (3): > > wifi: qtnfmac: Use netdev dummy allocator helper > > wifi: ath10k: allocate dummy net_device dynamically > > wifi: ath11k: allocate dummy net_device dynamically > > Thanks for setting up the branch, that makes the testing very easy. I > now tested the branch using the commit below with ath11k WCN6855 hw2.0 > on an x86 box: > > 5be9a125d8e7 wifi: ath11k: allocate dummy net_device dynamically > > But unfortunately it crashes, the stack trace below. I can easily test > your branches, just let me know what to test. A direct 'git pull' > command is the best. Thanks for the test. Reading the issue, I am afraid that freeing netdev explicitly (free_netdev()) might not be the best approach at the exit path. I would like to try to leverage the ->needs_free_netdev netdev mechanism to do the clean-up, if that makes sense. I've updated the ath11k patch, and I am curious if that is what we want. Would you mind testing a net patch I have, please? https://github.com/leitao/linux/tree/wireless-dummy_v2 PS: I didn't updated the other drivers (ath10k, qtnfmac, etc). Thank you!
