Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 4/1/2024 8:00 AM, Jeff Johnson wrote: > >> On 3/31/2024 11:32 AM, Karthikeyan Kathirvel wrote: >>> From: P Praneesh <quic_ppranees@xxxxxxxxxxx> >>> >>> Currently, the firmware returns incorrect pdev_id information in >>> WMI_PDEV_BSS_CHAN_INFO_EVENTID, leading to incorrect filling of >>> the pdev's survey information. >>> >>> To prevent this issue, when requesting BSS channel information >>> through WMI_PDEV_BSS_CHAN_INFO_REQUEST_CMDID, firmware expects >>> pdev_id as one of the arguments in this WMI command. >>> >>> Add pdev_id to the struct wmi_pdev_bss_chan_info_req_cmd and fill it >>> during ath12k_wmi_pdev_bss_chan_info_request(). This resolves the >>> issue of sending the correct pdev_id in WMI_PDEV_BSS_CHAN_INFO_EVENTID. >>> >>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >>> >>> Fixes: d889913205 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") >>> >> >> remove this blank line. Fixes tag should be together with S-o-b >> >>> Signed-off-by: P Praneesh <quic_ppranees@xxxxxxxxxxx> >>> Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@xxxxxxxxxxx> >> >> > Kalle can fix this when he merges into pending Did that now to both patches: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=8b2506bb2baa28a0e6ee5d4d71d7fca32e6da9d1 https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=d24b046bfc8f7255f4bef964ea5d9fc976273301 I also fixed this: ERROR: Commit id shorter than 12 digits: Fixes: d889913205 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") Should be: Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches