On 03/04/2024 16:12, Dmitry Baryshkov wrote: > From [Jeff's] message it looks like we are expected to get MSA READY even on msm8998. This is the code we're using: https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/drivers/net/wireless/ath/ath10k/qmi.c When ATH10K_SNOC_DRIVER_EVENT_SERVER_ARRIVE, driver registers an "indicator handler" ath10k_snoc_qmi_wlfw_clnt_ind() It handles QMI_WLFW_FW_READY_IND_V01 by posting ATH10K_SNOC_DRIVER_EVENT_FW_READY_IND which is handled in the ath10k_snoc_driver_event_work() work queue. But QMI_WLFW_MSA_READY_IND_V01 only triggers a debug log and setting qmi_cfg->msa_ready = true; $ git grep '\<msa_ready\>' drivers/net/wireless/ath/ath10k/qmi.c: qmi_cfg->msa_ready = true; drivers/net/wireless/ath/ath10k/qmi.c: qmi_cfg->msa_ready = false; drivers/net/wireless/ath/ath10k/qmi.h: * msa_ready: wlan firmware msa memory ready for board data download drivers/net/wireless/ath/ath10k/qmi.h: bool msa_ready; So basically, the vendor ath10k driver ignores QMI_WLFW_MSA_READY_IND_V01. I will test the following patch which aligns the behavior of mainline driver to that of vendor driver: diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c index 38e939f572a9e..0e1ab5aca663b 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -1040,6 +1040,7 @@ static void ath10k_qmi_driver_event_work(struct work_struct *work) switch (event->type) { case ATH10K_QMI_EVENT_SERVER_ARRIVE: ath10k_qmi_event_server_arrive(qmi); + ath10k_qmi_event_msa_ready(qmi); break; case ATH10K_QMI_EVENT_SERVER_EXIT: ath10k_qmi_event_server_exit(qmi); @@ -1048,7 +1049,7 @@ static void ath10k_qmi_driver_event_work(struct work_struct *work) ath10k_qmi_event_fw_ready_ind(qmi); break; case ATH10K_QMI_EVENT_MSA_READY_IND: - ath10k_qmi_event_msa_ready(qmi); + printk(KERN_WARNING "IGNORING MSA_READY INDICATOR"); break; default: ath10k_warn(ar, "invalid event type: %d", event->type); Dmitry Baryshkov reported: Works on sm8150, sdm845, qrb2210 Regards
