On 3/28/2024 1:16 PM, Johannes Berg wrote:
That's a big set, not sure I can review it all at once :)
+struct ieee80211_chans_per_hw {
+ u32 n_chans;
+ struct ieee80211_channel chans[];
That should probably use __counted_by() these days.
sure, will address this comment in the next version of the patch.
+ * @num_hw: number of underlying hardware for which the channels list are
"number of [...] hardware" sounds odd to me, perhaps 'devices'?
sure, will address this comment in the next version of the patch.
+ * advertised in @hw_chans, 0 if multi hardware is not support. Expect >2
+ * if multi hardware is support.
1, I guess, not >2 - and ==1 makes no sense really, maybe it should say
that?
sure, will address this comment in the next version of the patch.
--
Karthikeyan Periyasamy
--
கார்த்திகேயன் பெரியசாமி
