On 30/03/2024 19:23, Krzysztof Kozlowski wrote: > On 30/03/2024 19:20, Krzysztof Kozlowski wrote: > >> On 28/03/2024 18:36, Marc Gonzalez wrote: >> >>> The ath10k driver waits for an "MSA_READY" indicator >>> to complete initialization. If the indicator is not >>> received, then the device remains unusable. >>> >>> cf. ath10k_qmi_driver_event_work() >>> >>> Several msm8998-based devices are affected by this issue. >>> Oddly, it seems safe to NOT wait for the indicator, and >>> proceed immediately when QMI_EVENT_SERVER_ARRIVE. >> >> This is v2, so where is the changelog? > > Expecting reviewer to dig previous discussions will not help your case. > It helps reviewers if you provide necessary information, like resolution > of previous discussion in the changelog. > > I dig the previous discussion, since you did not mention it here, and it > seems you entirely ignored its outcome. That's not a DT property. > > NAK, sorry. Please go back to v1 and read the comments you got there. My apologies for omitting the changelog. And I don't blame you for missing the thread's resolution, since I made a bit of a mess of it with my various messages. The firmware-5.bin approach was deemed DOA since these files are parsed too late with respect to the required work-around. Thus, we went back to either DT or a to-be-written system used in the vendor driver. Jeff Johnson (one of the maintainers) concluded with: "But I'm OK with the DT option as well. Kalle?" Thus, I spun v2 to get Kalle's Ack, and more crucially to give a heads-up to the msm8998 users my patch would impact. Regards
