On Thu, 2024-03-28 at 11:22 +0530, Manish Dharanenthiran wrote:
>
> +int __ieee80211_link_reconfig_remove(struct ieee80211_local *local,
> + struct ieee80211_sub_if_data *sdata,
> + const struct cfg80211_link_reconfig_removal_params *params)
> +{
> + struct ieee80211_link_data *link;
> + int ret;
> +
> + if (!ieee80211_sdata_running(sdata))
> + return -ENETDOWN;
> +
> + if (sdata->vif.type != NL80211_IFTYPE_AP)
> + return -EINVAL;
> +
> + link = sdata_dereference(sdata->link[params->link_id], sdata);
> + if (!link)
> + return -ENOLINK;
> +
> + ret = drv_link_reconfig_remove(local, sdata, params);
> +
> + return ret;
Again ... remove the 'ret' variable, it serves no purpose at all.
> +}
> +
> +int ieee80211_update_link_reconfig_remove_status(struct ieee80211_vif *vif,
> + unsigned int link_id,
> + u8 tbtt_count, u64 tsf,
> + enum ieee80211_link_reconfig_remove_state status)
> +{
> + struct ieee80211_sub_if_data *sdata = vif_to_sdata(vif);
> +
> + if (vif->type != NL80211_IFTYPE_AP) {
> + sdata_err(sdata, "Discarding link reconfig status for unsupported vif type\n");
Uh, no. Remove that message please.
> +TRACE_EVENT(drv_link_reconfig_remove,
> + TP_PROTO(struct ieee80211_local *local,
> + struct ieee80211_sub_if_data *sdata,
> + const struct cfg80211_link_reconfig_removal_params *params),
> +
> + TP_ARGS(local, sdata, params),
> +
> + TP_STRUCT__entry(LOCAL_ENTRY
> + VIF_ENTRY
> + __field(u32, link_id)
> + __field(u16, count)
> + __dynamic_array(u8, frame, params->ie_len)
> + ),
All the same things about indentation apply here.
johannes
