> Sparse warns: > > drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y > > Workaround it by using the '?' operator. Compile tested only. Acked-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxx> > --- > v2: > > * use parenthesis > > drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c > index 450f4d221184..578013884e43 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c > @@ -523,7 +523,8 @@ mt7915_fw_debug_wm_set(void *data, u64 val) > > /* WM CPU info record control */ > mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0)); > - mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw.debug_wm); > + mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | > + (dev->fw.debug_wm ? 0 : BIT(0))); > mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_MASK_CLR_ADDR, BIT(5)); > mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_SOFT_ADDR, BIT(5)); > > -- > 2.39.2 > >
Attachment:
signature.asc
Description: PGP signature
