On Tue, 2024-03-26 at 20:34 +0100, Martin Blumenstingl wrote: > > Hello Ping-Ke, > > On Tue, Mar 26, 2024 at 2:48 AM Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > > Since only station mode has been tested on SDIO chips, only keep it support > > for SDIO chips to reflect correct supported features. > Overall I'm fine with this patch, thanks for taking care of it! > > I only have one small comment: the subject line should start with > "wifi: rtw88: ..." (currently it states rtw89) Ah. Somehow I made this mistake. I'm adding a rule to avoid this in my scripts locally. Thanks for pointing out this. > With that changed: > Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > > Also I'm hoping that some people will step up and find the missing > link to get AP mode working on SDIO chips. I currently don't have time > for this. > I hope so. Thanks for the effort you have made. :) Ping-Ke