On 3/25/2024 7:09 AM, Bartosz Golaszewski wrote: > On Mon, Mar 25, 2024 at 2:57 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: >> >> Bartosz Golaszewski <brgl@xxxxxxxx> writes: >> >>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >>> >>> Add a PCI compatible for the ATH11K module on QCA6390 and describe the >>> power inputs from the PMU that it consumes. >>> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >> >> [...] >> >>> +allOf: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + const: pci17cb,1101 >>> + then: >>> + required: >>> + - vddrfacmn-supply >>> + - vddaon-supply >>> + - vddwlcx-supply >>> + - vddwlmx-supply >>> + - vddrfa0p8-supply >>> + - vddrfa1p2-supply >>> + - vddrfa1p7-supply >>> + - vddpcie0p9-supply >>> + - vddpcie1p8-supply >> >> I don't know DT well enough to know what the "required:" above means, >> but does this take into account that there are normal "plug&play" type >> of QCA6390 boards as well which don't need any DT settings? >> > > Do they require a DT node though for some reason? I would not expect the "PC" flavor of the card to require DT. The "mobile" and "automotive" flavors would probably require it.
