On Mon, 2024-03-25 at 10:40 -0700, Ben Greear wrote: > It is needed because if FW crashes while you are trying to remove links, then link > removal would fail, which causes mac80211 to not clean up its links. OK. It should get back to some legal state after recovery though? > In case where you > are trying to delete the station, this causes un-cleaned links which caused crashes > back when I was creating this patch. My patch allows always cleaning up the links > regardless of driver errors in the teardown paths. Seems potentially more like driver errors. Or perhaps we should just ignore driver errors entirely? > Always possible some intervening changes made this less of a problem, especially since > MLO is disabled for be200 in upstream code anyway now. Well that's just temporary, but we've also done a lot of work on FW error recovery, though likely unrelated to this particular issue. > I can remove the extra logging if you are otherwise OK with the approach > but don't want the logs. Well it'd be nice to actually see what crashed, and maybe it should really be driver fixes? I don't really understand why mac80211 would crash on failure of link removal. johannes
