On Mon, Mar 25, 2024 at 3:37 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > Bartosz Golaszewski <brgl@xxxxxxxx> writes: > > > On Mon, Mar 25, 2024 at 2:57 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > > >> > >> Bartosz Golaszewski <brgl@xxxxxxxx> writes: > >> > >> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > >> > > >> > Add a PCI compatible for the ATH11K module on QCA6390 and describe the > >> > power inputs from the PMU that it consumes. > >> > > >> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > >> > >> [...] > >> > >> > +allOf: > >> > + - if: > >> > + properties: > >> > + compatible: > >> > + contains: > >> > + const: pci17cb,1101 > >> > + then: > >> > + required: > >> > + - vddrfacmn-supply > >> > + - vddaon-supply > >> > + - vddwlcx-supply > >> > + - vddwlmx-supply > >> > + - vddrfa0p8-supply > >> > + - vddrfa1p2-supply > >> > + - vddrfa1p7-supply > >> > + - vddpcie0p9-supply > >> > + - vddpcie1p8-supply > >> > >> I don't know DT well enough to know what the "required:" above means, > >> but does this take into account that there are normal "plug&play" type > >> of QCA6390 boards as well which don't need any DT settings? > > > > Do they require a DT node though for some reason? > > You can attach the device to any PCI slot, connect the WLAN antenna and > it just works without DT nodes. I'm trying to make sure here that basic > setup still works. > Sure, definitely. I there's no DT node, then the binding doesn't apply and the driver (the platform part of it) will not probe. > Adding also Johan and ath11k list. For example, I don't know what's the > plan with Lenovo X13s, will it use this framework? I guess in theory we > could have devices which use qcom,ath11k-calibration-variant from DT but > not any of these supply properties? > Good point. I will receive the X13s in a month from now. I do plan on upstreaming correct support for WLAN and BT for it as well. I guess we can always relax the requirements once a valid use-case appears? Bart > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
