On Wed, 2024-03-20 at 21:42 +0200, Bitterblue Smith wrote:
>
> These contain functions related to the dynamic mechanism, which runs
> every two seconds to adjust to changes in the environment.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
> ---
> v3:
> - No change.
>
> v2:
> - Patch is new in v2, split from patch 3/3 in v1.
> ---
> .../wireless/realtek/rtlwifi/rtl8192du/dm.c | 125 ++++++++++++++++++
> .../wireless/realtek/rtlwifi/rtl8192du/dm.h | 10 ++
> 2 files changed, 135 insertions(+)
> create mode 100644 drivers/net/wireless/realtek/rtlwifi/rtl8192du/dm.c
> create mode 100644 drivers/net/wireless/realtek/rtlwifi/rtl8192du/dm.h
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192du/dm.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/dm.c
> new file mode 100644
> index 000000000000..aa7032e0f71a
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/dm.c
> @@ -0,0 +1,125 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright(c) 2009-2012 Realtek Corporation.*/
> +
> +#include "../wifi.h"
> +#include "../base.h"
> +#include "../core.h"
> +#include "../rtl8192d/reg.h"
> +#include "../rtl8192d/def.h"
> +#include "../rtl8192d/dm_common.h"
> +#include "../rtl8192d/fw_common.h"
> +#include "../rtl8192d/phy_common.h"
> +#include "phy.h"
> +#include "dm.h"
> +#include "fw.h"
> +
> +#define UNDEC_SM_PWDB entry_min_undec_sm_pwdb
Not use. Please remove it.
I did grep, and found these are unnecessary. I don't know why people used
it to type shorter name. Why not just make entry_min_undec_sm_pwdb shorter?
drivers/net/wireless/realtek/rtlwifi$ git grep UNDEC_SM_PWDB
rtl8192d/dm_common.c:#define UNDEC_SM_PWDB entry_min_undec_sm_pwdb
rtl8192d/dm_common.c: rtlpriv->dm.UNDEC_SM_PWDB == 0) {
rtl8192d/dm_common.c: rtlpriv->dm.UNDEC_SM_PWDB;
rtl8192d/dm_common.c: rtlpriv->dm.UNDEC_SM_PWDB);
rtl8192d/dm_common.c: de_digtable->min_undec_pwdb_for_dm = rtlpriv->dm.UNDEC_SM_PWDB;
rtl8192de/dm.c:#define UNDEC_SM_PWDB entry_min_undec_sm_pwdb
rtl8192de/dm.c: (rtlpriv->dm.UNDEC_SM_PWDB == 0)) {
rtl8192de/dm.c: rtlpriv->dm.UNDEC_SM_PWDB;
rtl8192de/dm.c: rtlpriv->dm.UNDEC_SM_PWDB;
rtl8192du/dm.c:#define UNDEC_SM_PWDB entry_min_undec_sm_pwdb
[...]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192du/dm.h
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/dm.h
> new file mode 100644
> index 000000000000..d036cf722384
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/dm.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright(c) 2009-2012 Realtek Corporation.*/
> +
> +#ifndef __RTL92C_DM_H__
Use space instead of tab.
> +#define __RTL92C_DM_H__
Please correct its name.
> +
> +void rtl92du_dm_init(struct ieee80211_hw *hw);
> +void rtl92du_dm_watchdog(struct ieee80211_hw *hw);
> +
> +#endif
> --
> 2.43.2
