On Wed, Mar 20, 2024 at 05:25:52PM +0200, Kalle Valo wrote: > Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > > > On 3/19/2024 3:47 AM, Breno Leitao wrote: > >> Embedding net_device into structures prohibits the usage of flexible > >> arrays in the net_device structure. For more details, see the discussion > >> at [1]. > >> > >> Un-embed the net_device from struct ath10k by converting it > >> into a pointer. Then use the leverage alloc_netdev() to allocate the > >> net_device object at ath10k_core_create(). The free of the device occurs > >> at ath10k_core_destroy(). > >> > >> [1] https://lore.kernel.org/all/20240229225910.79e224cf@xxxxxxxxxx/ > >> > >> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx> > > > > NAK this based upon the ath11k patch results. > > > > As suggested there we should just use kmalloc/kfree to match the existing logic. > > BTW if the patch is not tested on a real device then it's good to > document that in the commit message with "Compile tested only" or > similar. Good to know. Thanks. I will add it to the next patches.
