On 3/20/2024 7:32 AM, Kalle Valo wrote: > Breno Leitao <leitao@xxxxxxxxxx> writes: > >> Embedding net_device into structures prohibits the usage of flexible >> arrays in the net_device structure. For more details, see the discussion >> at [1]. >> >> Un-embed the net_device from struct ath11k_ext_irq_grp by converting it >> into a pointer. Then use the leverage alloc_netdev() to allocate the >> net_device object at ath11k_ahb_config_ext_irq() for ahb, and >> ath11k_pcic_ext_irq_config() for pcic. >> >> The free of the device occurs at ath11k_ahb_free_ext_irq() for the ahb >> case, and ath11k_pcic_free_ext_irq() for the pcic case. >> >> [1] https://lore.kernel.org/all/20240229225910.79e224cf@xxxxxxxxxx/ >> >> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx> > > This crashes on my nuc x86 test box with WCN6855 hw2.0 when running > rmmod, stacktrace below. I used tag ath-202403201010 from my ath.git > tree as the baseline. Sorry that I'm not able to debug this further > right now. It seems to maintain the logic of the original that we should not use alloc_netdev() and free_netdev() but instead should just use kmalloc()/kfree().
