Hi Reinette, > This adds the infrastructure to support older firmware APIs. > The API version number is stored as part of the filename, we first try to > load the most recent firmware and progressively try lower versions. > The API version is also read from the firmware self and stored as part > of the iwl_priv structure. Only firmware that is supported by driver will > be loaded. The version number read from firmware is compared > to supported versions in the driver not the API version used as part of > filename. thanks for doing this. This can really help smooth upgrade path in case the firmware API changes. > -MODULE_FIRMWARE(IWL5000_MODULE_FIRMWARE); > -MODULE_FIRMWARE(IWL5150_MODULE_FIRMWARE); > +MODULE_FIRMWARE(IWL5000_MODULE_FIRMWARE(IWL5000_UCODE_API_MAX)); > +MODULE_FIRMWARE(IWL5150_MODULE_FIRMWARE(IWL5150_UCODE_API_MAX)); So we don't have clear semantics on how MODULE_FIRMWARE should be used. The current way is that it list all potential firmware versions. So in cases it support API -1 and -2, then it has to list both. And not only the latest. Personally I think we should not create too many macros here and just list all the firmware files manually. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
