On 3/14/2024 6:43 PM, Miaoqing Pan wrote: > The firmware memory was allocated in ath11k_pci_probe() or > ath11k_ahb_probe(), but not freed in ath11k_xxx_remove() in case > ATH11K_FLAG_QMI_FAIL bit is set. So call ath11k_fw_destroy() to > free the memory. > > Found while fixing the same problem in ath12k: > https://lore.kernel.org/linux-wireless/20240314012746.2729101-1-quic_miaoqing@xxxxxxxxxxx > > No functional changes, compile tested only. > > Signed-off-by: Miaoqing Pan <quic_miaoqing@xxxxxxxxxxx> > --- > drivers/net/wireless/ath/ath11k/ahb.c | 1 + > drivers/net/wireless/ath/ath11k/fw.c | 1 + > drivers/net/wireless/ath/ath11k/pci.c | 1 + My Qualcomm Innovation Center copyright checker reports: drivers/net/wireless/ath/ath11k/ahb.c copyright missing 2024 drivers/net/wireless/ath/ath11k/fw.c copyright missing 2024 Kalle, do you want a respin or will you handle this? With copyrights fixed you can add my: Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
