On 3/18/2024 9:02 AM, Jeff Johnson wrote: > On 3/17/2024 11:02 PM, Sowmiya Sree Elavalagan wrote: >> In case of firmware assert snapshot of firmware memory is essential for >> debugging. Add firmware coredump collection support for PCI bus. >> Collect RDDM and firmware paging dumps from MHI and pack them in TLV >> format and also pack various memory shared during QMI phase in separate >> TLVs. Add necessary header and share the dumps to user space using dev >> coredump framework. Coredump collection is disabled by default and can >> be enabled using menuconfig. Dump collected for a radio is 55MB >> approximately. >> >> Tested-on: qcn9274 hw2.0 PCI WLAN.WBE.1.2.1-00201-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@xxxxxxxxxxx> > > b4 shazam reports warnings when applying your patch: > > Applying: wifi: ath12k: Add firmware coredump collection support > /local/mnt/workspace/jjohnson/kernel/ath/.git/rebase-apply/patch:35: new blank line at EOF. > + > /local/mnt/workspace/jjohnson/kernel/ath/.git/rebase-apply/patch:230: new blank line at EOF. > + > /local/mnt/workspace/jjohnson/kernel/ath/.git/rebase-apply/patch:298: new blank line at EOF. > + > warning: 3 lines add whitespace errors. > > > And ath12k-check reports the following: drivers/net/wireless/ath/ath12k/coredump.h:1: Improper SPDX comment style for 'drivers/net/wireless/ath/ath12k/coredump.h', please use '/*' instead drivers/net/wireless/ath/ath12k/coredump.h:1: Missing or malformed SPDX-License-Identifier tag in line 1 drivers/net/wireless/ath/ath12k/coredump.h:59: line length of 94 exceeds 90 columns drivers/net/wireless/ath/ath12k/coredump.c:11: line length of 93 exceeds 90 columns drivers/net/wireless/ath/ath12k/pci.c:1339: Possible unnecessary 'out of memory' message drivers/net/wireless/ath/ath12k/pci.c:1388: line length of 100 exceeds 90 columns drivers/net/wireless/ath/ath12k/pci.c:1398: line length of 93 exceeds 90 columns
