On 14/03/2024 10:42, Kalle Valo wrote: > Kalle Valo <kvalo@xxxxxxxxxx> writes: > >> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes: >> >>> On 13/03/2024 10:58, Kalle Valo wrote: >>>> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes: >>>> >>>>> Create the new module rtl8192d-common and move some code into it from >>>>> rtl8192de. Now the rtl8192de driver (PCI) and the new rtl8192du driver >>>>> (USB) can share some of the code. >>>>> >>>>> This is mostly the code that required little effort to make it >>>>> shareable. There are a few more functions which they could share, with >>>>> some changes. >>>>> >>>>> The only other changes in this patch should be adjusting whitespace and >>>>> renaming some functions. >>>>> >>>>> Tested only with RTL8192DU. >>>>> >>>>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> >>>> >>>> A cover letter is would be really good to have. >>> >>> I can add one. What should I write in it? >> >> Basically just a short (few sentences) introduction what the patchset >> adds and if there are problematic/broken/todo items, for example in this >> case that the firmware upload is pending. This info helps the reviewers >> and also having the cover letters makes the grouping in email >> applications better. > > Here's a very good example of a cover letter: > > https://patchwork.kernel.org/project/linux-wireless/cover/20240311103735.615541-1-fiona.klute@xxxxxx/ > > The only gripe I have is that the version change log should be in > reverse order (v4, v3, v2 instead of v2, v3, v4) but that's just > cosmetics. > Okay, I will send v2 with a cover letter.
