On 13/03/2024 04:16, Ping-Ke Shih wrote: > On Wed, 2024-03-13 at 00:18 +0200, Bitterblue Smith wrote: >> >> Create the new module rtl8192d-common and move some code into it from >> rtl8192de. Now the rtl8192de driver (PCI) and the new rtl8192du driver >> (USB) can share some of the code. >> >> This is mostly the code that required little effort to make it >> shareable. There are a few more functions which they could share, with >> some changes. >> >> The only other changes in this patch should be adjusting whitespace and >> renaming some functions. > > Please run checkpatch.pl that reports > "total: 5 errors, 20 warnings, 67 checks, 9388 lines checked" > > I know you just move them from a place to another, but let's fix them > when touching. > All right, I will make checkpatch less unhappy. > > Two unused warnings on channel_all and > rtl92d_dm_check_txpower_tracking_thermal_meter (you also pointed it out) > > Ping-Ke > >
