On Wed, 2024-03-13 at 01:21 +0200, Bitterblue Smith wrote: > > rtl92d_dm_check_txpower_tracking_thermal_meter() is actually > unused in rtl8192de. Should I just delete it? > > I don't remember why I made it static, but that introduced > a warning. I feel we can set rtlpriv->dm.txpower_tracking = false, and then uncomment /* rtl92d_dm_check_txpower_tracking_thermal_meter(hw); */ More, this function appears twice: $ git grep rtl92d_dm_check_txpower_tracking_thermal_meter rtl8192de/dm.c:static void rtl92d_dm_check_txpower_tracking_thermal_meter(struct ieee80211_hw *hw) rtl8192de/dm.c: /* rtl92d_dm_check_txpower_tracking_thermal_meter(hw); */ rtl8192du/dm.c:void rtl92d_dm_check_txpower_tracking_thermal_meter(struct ieee80211_hw *hw) rtl8192du/dm.c: rtl92d_dm_check_txpower_tracking_thermal_meter(hw); I suppose you should move rtl92d_dm_check_txpower_tracking_thermal_meter() to dm_common.c. Ping-Ke
