On Tue, 2024-03-12 at 17:22 +0800, Kang Yang wrote: > > On 3/12/2024 4:16 PM, Johannes Berg wrote: > > On Tue, 2024-03-12 at 12:59 +0800, Kang Yang wrote: > > > Current mac80211 won't parsing puncturing bitmap when process EHT > > > Operation element in 6 GHz band or Bandwidth Indication element. This > > > leads to puncturing bitmap cannot be updated in related situations, such > > > as connecting to an EHT AP in 6 GHz band. > > > > > > So supplement parsing of puncturing bitmap for these elements. > > > > Hah, yes, I just noticed that too and fixed the second part yesterday, > > and was still thinking about how I could test the first part :-) > > > > Should we add validation for puncturing bitmap in > validate_chandef_by_6ghz_he_eht_oper()? > We already have, no? It calls ieee80211_chandef_he_6ghz_oper(), which checks cfg80211_chandef_valid(), which includes puncturing. johannes