Hi Isaev, On Sun, Mar 10, 2024 at 12:44 PM Isaev Ruslan <legale.legale@xxxxxxxxx> wrote: > > v9 changes: > - remove binary json/iw_json_printer > [snip] > > Signed-off-by: Isaev Ruslan <legale.legale@xxxxxxxxx> > --- > ...utput-options-to-iw-for-scan-results.patch | 3773 +++++++++++++++++ > Makefile | 2 +- > iw.c | 27 +- > json/Makefile | 19 + > json/iw_json_print.c | 221 + > json/iw_json_print.h | 35 + > json/json_writer.c | 298 ++ > json/json_writer.h | 76 + > json/main.c | 49 + > scan.c | 1187 +++--- > util.c | 333 +- > 11 files changed, 5281 insertions(+), 739 deletions(-) I think you need to work on your git processes. First things first: please consider staging your changes before committing and inspecting what you're committing there. It's a really good way to catch "silly" mistakes like "git add"ing the wrong file, etc. My process if I were working on this patch would be something like this: 1. Make changes to files 2. git status - note files that need to be staged 3. git add file1.c file2.h 4. git status - verify the files I've added are the correct ones and that I haven't missed anything 5. (optional) git diff --cached - verify the changes I've staged are all correct and make sense 6. git commit --amend - amend my commit with the latest set of changes 7. git format-patch -v 9 origin/main - generate patches for my branch 8. Send email with the patches generated in step 7 I also tend to delete the patches generated as soon as I'm done with them so I don't get confused about which ones are which version. Secondly: if you're using "git add --all" or "git commit -a" or "git add *" or something like that which commits or stages all files in the directory, please don't. You'll do less revisions of the patch and produce better patches for upstream if you spend the time to check your changes at every step. Finally: please add generated files to the .gitignore file (if there is one) this tells git to ignore those files and it won't report them in "git status" and won't stage or commit them. "git status" being "clean" with no untracked files or changes is a really reassuring way of knowing that your directory doesn't have any unexpected changes or anything like that and it also helps out with stuff like this. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/
