On Thu, Mar 07, 2024 at 09:48:31AM -0800, Breno Leitao wrote: > struct net_device shouldn't be embedded into any structure, instead, > the owner should use the priv space to embed their state into net_device. > > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_device from struct iwl_trans_pcie by converting it > into a pointer. Then use the leverage alloc_netdev() to allocate the > net_device object at iwl_trans_pcie_alloc. > > The private data of net_device becomes a pointer for the struct > iwl_trans_pcie, so, it is easy to get back to the iwl_trans_pcie parent > given the net_device object. > > [1] https://lore.kernel.org/all/20240229225910.79e224cf@xxxxxxxxxx/ > > Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx> Ah, nice! Thanks for doing this. I had to double-check the pointer-to-pointer stuff, but it makes sense to me now. :) Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> -- Kees Cook
