On 3/4/2024 12:23 PM, Isaev Ruslan wrote: > On Mon, 4 Mar 2024 at 22:00, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> >>> >>> If these changes prove valuable, I am prepared to continue working on >>> extending JSON output support throughout the tool. >>> Feedback is welcome and appreciated. >>> >> >> I'd prefer to look at it unmangled - can you resend it with whitespace >> preserving tools please? > > If I understood you correctly, you wanted to see the patch without whitespaces. > I have sent the patch v2 in a separate email. no, we want patches with correct whitespace/indentation all of the patches you've sent so far have multiple places where correct code indentation is not present. for example: + if (argc > 0 && strcmp(*argv, "-j") == 0) { + iw_json = 1; + new_json_obj(1, 0); //pretty print disabled + argc--; + argv++; + } Not sure how you are posting, but note that many e-mail clients mangle patches. Please refer to: <https://docs.kernel.org/process/email-clients.html>