> -----Original Message----- > From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > Sent: Tuesday, February 27, 2024 8:20 PM > To: linux-wireless@xxxxxxxxxxxxxxx > Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Subject: [PATCH 3/4] wifi: rtw88: 8821c: Fix beacon loss and disconnect > > Tenda U9 V2.0, which contains RTL8811CU, is practically unusable because > of frequent disconnections: > > Feb 23 14:46:45 ideapad2 wpa_supplicant[427]: wlp3s0f3u2: CTRL-EVENT-BEACON-LOSS > Feb 23 14:46:46 ideapad2 wpa_supplicant[427]: wlp3s0f3u2: CTRL-EVENT-DISCONNECTED > bssid=90:55:de:__:__:__ reason=4 locally_generated=1 > > Feb 23 14:46:52 ideapad2 wpa_supplicant[427]: wlp3s0f3u2: CTRL-EVENT-CONNECTED > - Connection to 90:55:de:__:__:__ completed [id=0 id_str=] > Feb 23 14:46:54 ideapad2 wpa_supplicant[427]: wlp3s0f3u2: CTRL-EVENT-BEACON-LOSS > Feb 23 14:46:55 ideapad2 wpa_supplicant[427]: wlp3s0f3u2: CTRL-EVENT-DISCONNECTED > bssid=90:55:de:__:__:__ reason=4 locally_generated=1 > > Feb 23 14:47:01 ideapad2 wpa_supplicant[427]: wlp3s0f3u2: CTRL-EVENT-CONNECTED > - Connection to 90:55:de:__:__:__ completed [id=0 id_str=] > Feb 23 14:47:04 ideapad2 wpa_supplicant[427]: wlp3s0f3u2: CTRL-EVENT-BEACON-LOSS > Feb 23 14:47:05 ideapad2 wpa_supplicant[427]: wlp3s0f3u2: CTRL-EVENT-DISCONNECTED > bssid=90:55:de:__:__:__ reason=4 locally_generated=1 > > This is caused by a mistake in the chip initialisation. This version of > the chip requires loading an extra AGC table right after the main one, > but the extra table is being loaded at the wrong time. Thanks for the finding. The rtw_chip_board_info_setup() can only do "software" things, and rtw_phy_load_tables() can really do IO. Add this to commit message if you think this can be clear. > > Move the extra AGC table loading to the right place. > > Fixes: 5d6651fe8583 ("rtw88: 8821c: support RFE type2 wifi NIC") > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>