On Tue, 2024-02-27 at 14:58 +0800, Kang Yang wrote: > > > > + if (arvif->vif->type != NL80211_IFTYPE_AP || !arvif->vif->p2p) > > > > this logic isn't applicable for NL80211_IFTYPE_P2P_GO ? > > The original intention here is to determine if it is P2P GO, if yes, > continue, otherwise return. > > > Maybe this judgment is a bit misleading, let me replace with > if (arvif->vdev_subtype != WMI_VDEV_SUBTYPE_P2P_GO) ? There's also ieee80211_vif_type_p2p(arvif->vif) != NL80211_IFTYPE_P2P_GO if you wanted to write it that way. @Jeff: NL80211_IFTYPE_P2P_GO is not used by mac80211 internally, it translates that to vif->type==NL80211_IFTYPE_AP && vif->p2p==true. johannes
