On February 22, 2024 1:29:57 PM Alexey Berezhok <a@xxxxxxxxxx> wrote:
In 'brcmf_cfg80211_start_ap()', not assume that
NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
an explicit check instead. Use local
variable 'closednet' to pass in function call and
use for error message. Compile tested only.
Addition for the following patch
commit f20073f50dfd1 ("wifi: brcmfmac: do not cast hidden SSID
attribute value to boolean")
Thanks for the new revision. Although there was a remark about using string_choices.h instead of open coding 'val ? "enable" : "disable" ' I think that can be done driver wide. Pretty sure the are more instances of that. Maybe worth writing a coccinelle patch for that. So for this one...
Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Alexey Berezhok <a@xxxxxxxxxx> --- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
