Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> wrote: > The driver currently raises the following sparse warning: > [...] cfg80211.c:360:42: warning: incorrect type in assignment (different > base types) > [...] cfg80211.c:360:42: expected unsigned int key_mgmt_suite > [...] cfg80211.c:360:42: got restricted __be32 [usertype] > CHECK drivers/net/wireless/microchip/wilc1000/netdev.c > > This conversion was needed because historically the external supplicant > (observed with wpa_supplicant) expects AKM suite as big endian in > NL80211_CMD_EXTERNAL_AUTH message when the AKM suite is WLAN_AKM_SUITE_SAE. > This is not needed anymore: > - new (to be released) versions of wpa_supplicant now reads it in host > endian _while_ keeping compatibility for older drivers > - for new drivers used with current/old wpa_supplicant, this conversion has > been added to nl80211 to force big endian when the AKM suite is > WLAN_AKM_SUITE_SAE > > Remove this not-needed-anymore conversion to fix the sparse warning. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202308290615.lUTIgqUl-lkp@xxxxxxxxx/ > Tested-on: WILC1000 hwB SPI WILC_WIFI_FW_REL_16_1-13452 > Signed-off-by: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. 00413dd36414 wifi: wilc1000: remove AKM suite be32 conversion for external auth request -- https://patchwork.kernel.org/project/linux-wireless/patch/20240215-nl80211_fix_akm_suites_endianness-v1-2-57e902632f9d@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
