> -----Original Message----- > From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > Sent: Friday, February 16, 2024 2:58 AM > To: linux-wireless@xxxxxxxxxxxxxxx > Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Subject: [PATCH v2] wifi: rtlwifi: rtl8192cu: Fix TX aggregation > > rtl8192cu is checking rtl_mac.tids when deciding if it should enable > aggregation. This is wrong because rtl_mac.tids is not initialised > anywhere. Check rtl_sta_info.tids instead, which is initialised. > > Also, when enabling aggregation also enable RTS. The vendor driver does > this, my router does this. It seems like the thing to do. > > Also also, it seems right to set the AMPDU density only when enabling > aggregation. > > Also also also, delete the unused member rtl_mac.tids and the unused > macros RTL_AGG_ON and RTL_AGG_OFF. > > Naturally, with working AMPDU the download/upload speeds are better. > Before: 59/32 Mbps. > After: 68/46 Mbps. > > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Thanks!
