Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean

Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> · Wed, 14 Feb 2024 12:44:17 +0100

On February 14, 2024 11:28:28 AM Alexey Berezhok <a@xxxxxxxxxx> wrote:

12.02.2024 19:00, Arend van Spriel wrote:
On 2/12/2024 4:38 PM, Kalle Valo wrote:
Alexey Berezhok <a@xxxxxxxxxx> wrote:

In 'brcmf_cfg80211_start_ap()', not assume that
NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
an explicit check instead. Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Alexey Berezhok <a@xxxxxxxxxx>

Patch applied to wireless-next.git, thanks.

f20073f50dfd wifi: brcmfmac: do not cast hidden SSID attribute value
to boolean

Alexey,

Can you do a follow-up patch addressing my comment? If not I will do it
myself.

Regards,
Arend
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240208085121.2430-1-a@xxxxxxxxxx/

Hello, do you mean this kind of modification:

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 63f6e9436..d8f7bd5ce 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -5269,7 +5269,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy,
struct net_device *ndev,
       }

       err = brcmf_fil_iovar_int_set(ifp, "closednet",
-                                             settings->hidden_ssid);
+                                             (settings->hidden_ssid ==
NL80211_HIDDEN_SSID_NOT_IN_USE? 0 : 1));
       if (err) {
               bphy_err(drvr, "%s closednet error (%d)\n",
                        (settings->hidden_ssid !=
NL80211_HIDDEN_SSID_NOT_IN_USE) ?

If so, I will make additional patch.

That was indeed what I meant. Consider using local variable 'closednet' to 
pass in function call and use for error message.

Regards,
Arend

Regards,
Alexey



Attachment:
smime.p7s

Description: S/MIME Cryptographic Signature




