On Tue, 2024-02-13 at 14:54 +0200, Kalle Valo wrote:
>
> Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes:
>
> > The rcu_read_unlock() is accidentally added, and sparse warn:
> >
> > drivers/net/wireless/realtek/rtw89/fw.c:2807:17:
> > warning: context imbalance in 'rtw89_fw_h2c_assoc_cmac_tbl_g7' - unexpected unlock
> >
> > Fixes: b82730bf57b5 ("wifi: cfg80211/mac80211: move puncturing into chandef")
> > Cc: Johannes Berg <johannes.berg@xxxxxxxxx>
> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> Commit b82730bf57b5 is in wireless-next so I'll queue this patch to
> wireless-next as well, right?
I think yes.
>
> This again shows how important it is to fix all the remainging sparse
> warnings in wireless code so that we don't miss important warnings like
> this. If there just would be a way to get the cleanup patch submitters
> to fix the sparse warnings, sigh.
>
In short term, can we record the count of warnings and ensure it
doesn't increase while new commits are getting merged?
Ping-Ke
