Hi, > > The other thing here is that I'm not entirely sure how the driver works, > > chances are that this was previously a bug, and now is still a bug, > > unless the driver doesn't really support channel contexts, or any form > > of concurrency. > > This function is to initialize a station instance in firmware while > associating, and the field of firmware command is to tell MAC hardware > the sub-channels it can use to transmit, which should rely on > bitmap of puncturing. Initially, we just wanted the field value to > be ~0 (0xFFFF) to prevent TX stuck, but not fully implemented puncturing > feature. > > I think this is the reason you are confused. Not sure that explanations helps ;-) If you have this per station how do you handle CCA? Which was kind of the reason I moved it all back to the chandef? Not that this didn't make the code simpler (in mac80211) either as a nice side effect :-) > Thanks for this hint. I will check my colleagues about the detail of > puncturing behavior next week, because people are offline for the lunar > new year. Right. > I will also check people about the beacon CSA mentioned in > another discussion thread. Thanks! > > Though it _looks_ like you only support one channel context there, so > > maybe also only one vif, and it doesn't matter? I'd probably still move > > it over to the chan.c code though, it really does belong there more as > > discussed in the commit message of this change. > > > > But I didn't want to make those more semantic changes because I don't > > know what logic your device applies here. > > We are going to support MCC and MLO, so we will/must consider more than > one channel context. Currently, rtw89 just consider 'deflink' not actually > 'links' that is the next main work we are doing. For MLO you have just one vif still, so it doesn't matter. Looks like MCC is something with multi-vif (looking at your other patchset) so there that makes sense. Not that I know what "MCC" means :) > > And sorry about the locking bug! Not sure how that happened :( > > > > I will send a patch to fix locking ahead. > Great, thanks a lot! johannes
