tree: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main head: d4655db0a1e11eeacc55c44c81121c83b087982e commit: 74f4cd71070538bd9a8b6686fc53e7b77d510afa [62/81] wifi: iwlwifi: take SGOM and UATS code out of ACPI ifdef config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20240209/202402091914.TvQ2OSQY-lkp@xxxxxxxxx/config) compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240209/202402091914.TvQ2OSQY-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202402091914.TvQ2OSQY-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/net/wireless/intel/iwlwifi/fw/uefi.c:359:6: error: redefinition of 'iwl_uefi_get_sgom_table' 359 | void iwl_uefi_get_sgom_table(struct iwl_trans *trans, | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/intel/iwlwifi/fw/uefi.c:11: drivers/net/wireless/intel/iwlwifi/fw/uefi.h:294:6: note: previous definition of 'iwl_uefi_get_sgom_table' with type 'void(struct iwl_trans *, struct iwl_fw_runtime *)' 294 | void iwl_uefi_get_sgom_table(struct iwl_trans *trans, struct iwl_fw_runtime *fwrt) | ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/intel/iwlwifi/fw/uefi.c:392:5: error: redefinition of 'iwl_uefi_get_uats_table' 392 | int iwl_uefi_get_uats_table(struct iwl_trans *trans, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/intel/iwlwifi/fw/uefi.h:299:5: note: previous definition of 'iwl_uefi_get_uats_table' with type 'int(struct iwl_trans *, struct iwl_fw_runtime *)' 299 | int iwl_uefi_get_uats_table(struct iwl_trans *trans, | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/iwl_uefi_get_sgom_table +359 drivers/net/wireless/intel/iwlwifi/fw/uefi.c c593d2fae592ae Ayala Barazani 2021-12-04 358 c593d2fae592ae Ayala Barazani 2021-12-04 @359 void iwl_uefi_get_sgom_table(struct iwl_trans *trans, c593d2fae592ae Ayala Barazani 2021-12-04 360 struct iwl_fw_runtime *fwrt) c593d2fae592ae Ayala Barazani 2021-12-04 361 { c593d2fae592ae Ayala Barazani 2021-12-04 362 struct uefi_cnv_wlan_sgom_data *data; 0c4bad7f47c4e5 Ard Biesheuvel 2022-06-17 363 int ret; c593d2fae592ae Ayala Barazani 2021-12-04 364 8ae3e23195188a Gregory Greenman 2023-06-06 365 if (!fwrt->geo_enabled) c593d2fae592ae Ayala Barazani 2021-12-04 366 return; c593d2fae592ae Ayala Barazani 2021-12-04 367 a6dfe1e7440308 Miri Korenblit 2024-01-28 368 data = iwl_uefi_get_verified_variable(trans, IWL_UEFI_SGOM_NAME, a6dfe1e7440308 Miri Korenblit 2024-01-28 369 "SGOM", sizeof(*data), NULL); a6dfe1e7440308 Miri Korenblit 2024-01-28 370 if (IS_ERR(data)) 0c4bad7f47c4e5 Ard Biesheuvel 2022-06-17 371 return; c593d2fae592ae Ayala Barazani 2021-12-04 372 c593d2fae592ae Ayala Barazani 2021-12-04 373 ret = iwl_uefi_sgom_parse(data, fwrt); c593d2fae592ae Ayala Barazani 2021-12-04 374 if (ret < 0) c593d2fae592ae Ayala Barazani 2021-12-04 375 IWL_DEBUG_FW(trans, "Cannot read SGOM tables. rev is invalid\n"); c593d2fae592ae Ayala Barazani 2021-12-04 376 c593d2fae592ae Ayala Barazani 2021-12-04 377 kfree(data); c593d2fae592ae Ayala Barazani 2021-12-04 378 } c593d2fae592ae Ayala Barazani 2021-12-04 379 IWL_EXPORT_SYMBOL(iwl_uefi_get_sgom_table); 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 380 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 381 static int iwl_uefi_uats_parse(struct uefi_cnv_wlan_uats_data *uats_data, 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 382 struct iwl_fw_runtime *fwrt) 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 383 { 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 384 if (uats_data->revision != 1) 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 385 return -EINVAL; 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 386 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 387 memcpy(fwrt->uats_table.offset_map, uats_data->offset_map, 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 388 sizeof(fwrt->uats_table.offset_map)); 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 389 return 0; 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 390 } 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 391 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 @392 int iwl_uefi_get_uats_table(struct iwl_trans *trans, 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 393 struct iwl_fw_runtime *fwrt) 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 394 { 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 395 struct uefi_cnv_wlan_uats_data *data; 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 396 int ret; 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 397 a6dfe1e7440308 Miri Korenblit 2024-01-28 398 data = iwl_uefi_get_verified_variable(trans, IWL_UEFI_UATS_NAME, a6dfe1e7440308 Miri Korenblit 2024-01-28 399 "UATS", sizeof(*data), NULL); a6dfe1e7440308 Miri Korenblit 2024-01-28 400 if (IS_ERR(data)) 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 401 return -EINVAL; 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 402 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 403 ret = iwl_uefi_uats_parse(data, fwrt); 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 404 if (ret < 0) { 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 405 IWL_DEBUG_FW(trans, "Cannot read UATS table. rev is invalid\n"); 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 406 kfree(data); 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 407 return ret; 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 408 } 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 409 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 410 kfree(data); 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 411 return 0; 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 412 } 4a9bb5b4d94999 Mukesh Sisodiya 2023-10-22 413 IWL_EXPORT_SYMBOL(iwl_uefi_get_uats_table); 427661e4c48887 Miri Korenblit 2024-01-31 414 :::::: The code at line 359 was first introduced by commit :::::: c593d2fae592aefaec86f012e1354400b8ac4715 iwlwifi: support SAR GEO Offset Mapping override via BIOS :::::: TO: Ayala Barazani <ayala.barazani@xxxxxxxxx> :::::: CC: Luca Coelho <luciano.coelho@xxxxxxxxx> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
