On Thu, 2024-02-01 at 02:55 +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote: > > However, in the patch, please take care of disabling 'wilc->rtc_clk' in > wilc_bus_probe() for the failure condition. > > static int wilc_bus_probe(struct spi_device *spi) { > ... > +power_down: > + clk_disable_unprepare(wilc->rtc_clk); > + wilc_wlan_power(wilc, false); > netdev_cleanup: > wilc_netdev_cleanup(wilc); Good catch - I fixed that in v5. > I hope this patch is tested for failure scenario(when WILC1000 SPI > device is not connected) as well. Yep. --david