Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 1/28/2024 10:57 PM, Raj Kumar Bhagat wrote: >> From: P Praneesh <quic_ppranees@xxxxxxxxxxx> >> >> Currently only one MHI device is registered successfully on platform >> having two or more identical MHI devices. This is beacuse QMI service >> runs with identical QRTR node ID. And, qrtr-lookup cannot register >> more than one QMI service with identical node ID. >> >> Hence, generate a unique QRTR instance ID from PCIe domain number and >> bus number. QMI allows node id to be written on scratch register. >> Add logic to write QRTR node id to the register. It is available for >> firmware to uniquely identify an instance. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1 >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 >> >> Depends-On: wifi: ath12k: add firmware-2.bin support > > I would not expect this information to be part of the final commit text, > but I suspect Kalle can remove it when it goes into the pending branch Yes, I removed Depends-On. In the future, please add it to the cover letter or, if there's no cover letter, after "---" line. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches